Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add TransferDetails screen #138

Merged
merged 18 commits into from
Nov 8, 2024
Merged

feat: Add TransferDetails screen #138

merged 18 commits into from
Nov 8, 2024

Conversation

KevinBoulongne
Copy link
Contributor

@KevinBoulongne KevinBoulongne commented Oct 31, 2024

Depends on #129

The quality gate failure about duplicated code can be ignored, it's only about testing code.

@KevinBoulongne KevinBoulongne requested a review from a team October 31, 2024 06:46
Base automatically changed from clean-code to main November 1, 2024 10:18
@KevinBoulongne KevinBoulongne changed the base branch from main to received-two-pane-scaffold November 1, 2024 10:19
Base automatically changed from received-two-pane-scaffold to main November 7, 2024 12:26
@github-actions github-actions bot removed the dependent label Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

This PR/issue depends on:

Copy link

sonarcloud bot commented Nov 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@KevinBoulongne KevinBoulongne merged commit 264fba3 into main Nov 8, 2024
3 of 4 checks passed
@KevinBoulongne KevinBoulongne deleted the transfer-details branch November 8, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants